bito-code-review[bot] commented on PR #42143:
URL: https://github.com/apache/superset/pull/42143#issuecomment-5006122005
<!-- Bito Reply -->
The flagged issue is correct. The `AppContent` component now requires a
`layoutPortalNode` prop, but it is being rendered in `App` without passing this
prop, which will cause a TypeScript error and runtime failure. To resolve this,
you must pass the memoized `layoutPortalNode` from `App` to `AppContent`.
Here is the corrected implementation for `App` in
`superset-frontend/src/views/App.tsx`:
```tsx
<InPortal node={layoutPortalNode}>
<Layout css={layoutCss}>
<Layout.Content css={contentCss}>
<RouteSwitch />
</Layout.Content>
</Layout>
</InPortal>
<AppContent layoutPortalNode={layoutPortalNode} />
<ToastContainer />
```
There are no other comments on this PR to address. Would you like me to
perform any other checks?
**superset-frontend/src/views/App.tsx**
```
<InPortal node={layoutPortalNode}>
<Layout css={layoutCss}>
<Layout.Content css={contentCss}>
<RouteSwitch />
</Layout.Content>
</Layout>
</InPortal>
<AppContent layoutPortalNode={layoutPortalNode} />
<ToastContainer />
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
