rusackas commented on PR #42118: URL: https://github.com/apache/superset/pull/42118#issuecomment-5006213599
Thanks @eschutho, this looks like a solid fix. Pre-commit's failing since `ruff-format` wants to reformat `webdriver_test.py`, so a `pre-commit run --all-files` (or using the pre-commit hook when committing locally) should clear that. The rest of the failures (changes, frontend-build, playwright, etc.) look like the change-detector step hit a GitHub 503, so that's probably just a flaky rerun rather than anything in the diff. I just opened a PR for this separately so it retries. Codeant's logic-error thread on the stale `remaining_budget` calc (computed before the scroll-settle sleep) is worth a look. The type-annotation nits from the same bot I wouldn't necessarily worry about, but there's a pile of open bot threads to assess/address/resolve, if you don't mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
