rusackas commented on PR #41851: URL: https://github.com/apache/superset/pull/41851#issuecomment-5006880078
Thanks for digging into this, @devsarthak2005, and for the thorough tests here. Really appreciate the effort. Having looked at both, I'm leaning toward landing #41804 and closing this one, if that's OK with you. The main thing is that #41804 fixes it down at the query layer in `models/helpers.py`, so it covers both the legacy table and the ag-grid plugin in one spot, and it casts the UUID columns to string so they stay searchable rather than getting hidden from the Search By dropdown. Felt a bit friendlier to keep them searchable, since folks do paste a partial UUID to find a row. Your approach is totally valid, it's just coming at it from the other direction, and I don't think we'd want both since they'd more or less cancel each other out. Would you and @EnxDev be up for reviewing #41804 before it goes in? You've both been deep in this one, so your eyes would be really valuable. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
