rusackas opened a new pull request, #42210: URL: https://github.com/apache/superset/pull/42210
See #40273 ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Enable errors for the `"Query" object is being merged into a Session along the backref cascade path` RemovedIn20Warning, and fix the code that relied on the reverse cascade. - `Database.queries` backref now sets `cascade_backrefs=False`, which is the SQLAlchemy 2.0 behavior: constructing `Query(database=...)` no longer implicitly merges the new object into the Database's session. All code paths that persist queries already call `session.add()` explicitly. - `SupersetSecurityManager.raise_for_access` builds an ephemeral `Query` for access checks and unconditionally expunged it from the session. Since the object is no longer implicitly merged, the expunge is now guarded, matching the existing pattern in `Database.resolve_default_schema`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ``` $ SQLALCHEMY_WARN_20=1 TZ=UTC python3 -m pytest tests/unit_tests/ ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
