eschutho opened a new pull request, #42218: URL: https://github.com/apache/superset/pull/42218
**Decisions made that were not in the instructions** None. ## What was the warning? Production logs show `Superset.explore_json This API endpoint is deprecated and will be removed in version 5.0.0` — emitted by the shared `@deprecated()` decorator in `superset/views/base.py`, used across several endpoints in `superset/views/core.py` (`explore_json`, `explore_json_data`, `warm_up_cache`, etc). ## What changed When a `@deprecated()` call site sets `new_target`, the message concatenation left a stray space before the period: ``` "...will be removed in version 5.0.0 . Use the following API endpoint instead: /api/v1/chart/data" ``` instead of the intended: ``` "...will be removed in version 5.0.0. Use the following API endpoint instead: /api/v1/chart/data" ``` One-character fix: `" . Use..."` → `". Use..."` in `superset/views/base.py`. Added a regression test (`test_deprecated_new_target_message_has_no_stray_space`) asserting the formatted message has no stray space before the period. ## No-behavior-change note This only touches the deprecation warning's log message text. It does not change the deprecated endpoint's behavior, routing, permissions, or the `@deprecated()` decorator's once-per-process warning semantics. The `explore_json` endpoint itself remains deprecated and unchanged — it's an intentional, architectural deprecation and out of scope here. Note #41714 is a separate in-flight effort to remove the legacy `explore_json`/`viz.py` pipeline entirely; this PR is just a stopgap message-hygiene fix for current production logs in the meantime. ## Test plan - `tests/unit_tests/views/test_base.py` — added `test_deprecated_new_target_message_has_no_stray_space`; ran the full file (32 tests) locally, all pass. - `ruff check` / `ruff format --check` clean. - Full `pre-commit run` clean (mypy, ruff, pylint, etc.). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
