bito-code-review[bot] commented on code in PR #38807:
URL: https://github.com/apache/superset/pull/38807#discussion_r3611114907
##########
superset-frontend/src/pages/DatasetList/index.tsx:
##########
@@ -57,6 +57,8 @@ import {
DatasetTypeLabel,
Loading,
List,
+ RlsBadge,
+ type RlsFilterSummary,
Review Comment:
<!-- Bito Reply -->
The suggestion to add test coverage for the RLS badge is appropriate. As a
new UI component, verifying its behavior with both positive (filters present)
and negative (no filters) test cases is a standard best practice to ensure
reliability and prevent regressions. You should proceed with adding these test
fixtures to the `DatasetList.testHelpers.tsx` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
