hy144328 commented on code in PR #41980:
URL: https://github.com/apache/superset/pull/41980#discussion_r3611299439
##########
superset/utils/core.py:
##########
@@ -641,9 +641,7 @@ def generic_find_constraint_name(
table: str, columns: set[str], referenced: str, database: SQLAlchemy
) -> str | None:
"""Utility to find a constraint name in alembic migrations"""
- tbl = sa.Table(
- table, database.metadata, autoload=True, autoload_with=database.engine
- )
+ tbl = sa.Table(table, database.metadata, autoload_with=database.engine)
Review Comment:
In general, I agree with the bot.
However, is this a regression?
The scope of the PR is to refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
