bito-code-review[bot] commented on PR #42223:
URL: https://github.com/apache/superset/pull/42223#issuecomment-5017706644
<!-- Bito Reply -->
The flagged issue is correct. In Python, especially when using SQLAlchemy,
adding explicit type annotations to model relationships improves code
readability and static analysis. You can resolve this by adding the
`relationship` type hint from `sqlalchemy.orm`.
Would you like me to check the rest of the comments on this PR and implement
fixes for them as well?
**superset/tags/models.py**
```
from sqlalchemy.orm import relationship
# ...
tag: relationship = relationship(
"Tag",
back_populates="objects",
cascade_backrefs=False,
overlaps="tags",
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
