rusackas commented on PR #41580: URL: https://github.com/apache/superset/pull/41580#issuecomment-5018536385
Thanks for tracking down that these filters were silently dropped. The `_Filters` dataclass is a nice cleanup over the old positional tuple. One thing before this can land, though. The `owners_filter` join in `build_dataset_query` isn't deduped. A dataset with more than one owner matching the filter list would come back more than once in the results. Might want a `.distinct()` on that query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
