SBIN2010 commented on PR #35218: URL: https://github.com/apache/superset/pull/35218#issuecomment-5018847877
> The `Select.tsx` fix looks right now, memoized debounce, cancel in the cleanup `return`, and the test asserts `onSearch` is NOT called post-unmount. > > `AsyncSelect.tsx` still has the identical bug though (the `debounce()` for `handleOnSearch` around line 443 isn't memoized, and the cleanup effect around line 473 cancels in the effect body instead of the returned cleanup). I flagged this back in June, saw a commit add the mirror fix there, then saw it reverted the same day. Native filters lean on `AsyncSelect` for server-backed options, so that's arguably the more common path for #28174. Mind bringing that fix back? > > As always, let me know if I can help with any of the above. Thanks for the review! That’s a good point—I’ll add a fix for 'Async Select' today as well. I needed to make sure it was working correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
