jesperct commented on PR #41912: URL: https://github.com/apache/superset/pull/41912#issuecomment-5022297734
Added keyboard support in 7e5d662177. The card wrapper now has `role="button"`, `tabIndex`, and an `aria-label` with the query name, and Enter or Space opens the query using the `handleKeyboardActivation` util from #42009. One snag worth mentioning: that util calls `preventDefault()` before the callback runs, so a keydown bubbling up from the kebab button both navigated and swallowed the click that opens the menu. The handler now ignores events that didn't start on the wrapper itself, and there's a test covering it. Heads up on the lint rule as well: it won't catch this on these cards, since `CardStyles` is a styled component and jsx-a11y only checks intrinsic elements. `DashboardCard`'s wrapper has the same gap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
