rusackas commented on PR #39528: URL: https://github.com/apache/superset/pull/39528#issuecomment-5024916558
Thanks @guptapuja! `pre-commit` is still failing, this time on `types.ts`: the latest push collapses the `ImportResourceName` union onto one line and prettier wants it multi-line. That hunk isn't related to this fix, so reverting it should clear things up. As mentioned, a small test covering the `refreshKey` bump would be appreciated too. Holler if you want a hand with either. Happy to help get this across the finish line if you're OK with me pushing some commits here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
