rusackas commented on PR #37367: URL: https://github.com/apache/superset/pull/37367#issuecomment-5024921432
Thanks for slimming this down, @YuriyKrasilnikov! The ordering fix still holds up. `initFeatureFlags` on `master` still sits below the language-pack awaits. Two things before we can merge, though. The branch conflicts with `master` again (the language-pack loading got reworked to prefer inlined bootstrap data), and the new test is red on this PR's own CI. It expects `/superset/language_pack/fr/` but the code builds the URL with `makeUrl()`, so it fetches `/language_pack/fr/`. That assertion will need rework along with the rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
