rusackas commented on PR #39469: URL: https://github.com/apache/superset/pull/39469#issuecomment-5025539445
Did another sweep of the review threads now that CI's green. The latest refactor addressed most of what was open (typed constants, the shared-cache refresh on stamp bumps, the generator error handling, the audit event @EnxDev asked for, and more), so I resolved those to cut the noise. Two left open on purpose. The lockout/rate-limit keys in `AUTH_DB_CONFIG` still aren't consumed anywhere... the docs now call them reserved, but I'd lean toward dropping them until a pillar actually wires them up, curious what you think @shantanukhond. And the OpenAPI docstring for the password endpoint maps 429 to the 400 response component, which needs a proper 429 component (there isn't one yet). Thanks for grinding through the fixes, this is looking close! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
