rusackas commented on PR #36262:
URL: https://github.com/apache/superset/pull/36262#issuecomment-5028830038
@Yogi776 checking back in here since it's been quiet a bit. As mentioned
above, `value_dict.get("id")` in `get_with_name` won't work against a real
dashboard payload, the cached value is a `DataMaskStateWithId` map keyed by
filter id, not a flat object with a top-level `id`, so `name` comes back `None`
in practice. The new tests only pass because the fixture is a flat `{"id":
...}` object that doesn't match what the frontend actually sends. Want to take
another pass at pulling the name from `native_filter_configuration` instead, or
should I adopt this or (if possible) fix it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
