hy144328 commented on code in PR #42277:
URL: https://github.com/apache/superset/pull/42277#discussion_r3624723063


##########
superset/models/core.py:
##########
@@ -644,7 +644,7 @@ def _get_sqla_engine(  # pylint: disable=too-many-locals  # 
noqa: C901
                 if cached := _ENGINE_CACHE.get(cache_key):
                     return cached
         try:
-            engine = create_engine(sqlalchemy_url, **engine_kwargs)
+            engine = create_engine(sqlalchemy_url, future=True, 
**engine_kwargs)

Review Comment:
   Addressed by 
[ff9d04f](https://github.com/apache/superset/pull/42277/commits/ff9d04ff536e7661cffc4e9247c89f73cc6bd778).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to