bito-code-review[bot] commented on PR #38019:
URL: https://github.com/apache/superset/pull/38019#issuecomment-5037661058
<!-- Bito Reply -->
The flagged issue is correct. The current implementation catches exceptions
during the GeoJSON download and load process but continues execution, resulting
in the use of stale Natural Earth geometry. To resolve this, you should raise
an exception or explicitly clear the `kenya_copy` variable in the `except`
block to ensure the notebook fails or stops if the new data cannot be loaded.
**superset-frontend/plugins/legacy-plugin-chart-country-map/scripts/Country
Map GeoJSON Generator.ipynb**
```
except Exception as e:
print(f"Unable to download or load the GeoJSON file for Kenya. Error:
{str(e)}")
raise e
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
