rusackas commented on code in PR #42300:
URL: https://github.com/apache/superset/pull/42300#discussion_r3629017215
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -724,6 +724,40 @@ export default function transformProps(
}
}
+ // When explicit Y axis bounds are set, clamp series values to those bounds
+ // instead of leaving raw out-of-range values in place. ECharts axis
+ // clipping can otherwise drop an out-of-bounds point (and the line
+ // segments around it) entirely rather than truncating it at the
+ // boundary (see https://github.com/apache/superset/issues/27449).
+ if (yAxisMin !== undefined || yAxisMax !== undefined) {
Review Comment:
Fair point, the comment overstated it — bounds get set from derived data too
(shouldCalculateDataBounds, log axis floor, etc.), not just explicit user
config. Reworded to cover both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
