hughhhh commented on PR #42284:
URL: https://github.com/apache/superset/pull/42284#issuecomment-5045805409
## How Has This Been Tested? (real full stack, Docker)
Validated end-to-end against the live stack (Flask + Celery worker +
Postgres + Redis + MinIO/S3 + Mailpit/SMTP) serving this branch via bind mount.
**Bring-up** (from workspace root, with the S3/SMTP verify overlay):
```
docker compose -p amman-excel -f docker-compose.yml -f
docker-compose-excel-verify.yml \
up -d superset superset-worker superset-init minio createbucket mailpit
```
**Test case — the natural one:** Superset's example dashboards ship charts
that have **no saved `query_context`** (they store `params` only), which is
exactly the state this PR handles. The **Video Game Sales** dashboard (8
charts, all with `query_context = NULL`) mixes eligible and ineligible viz
types, so one export exercises both code paths:
- **Eligible → rebuilt from form data & exported** (3 sheets, real data):
- `51 - Games` (`table`) — **16,595 rows**
- `58 - Publishers With Most Titles` (`table`) — 10 rows
- `53 - Most Dominant Platforms` (`pie`) — groupby + `SUM(Global_Sales)`
- **Ineligible → skipped & listed in the email** (`echarts_timeseries_bar`
×2, `heatmap_v2`, `treemap_v2` ×2): charts 54, 55, 56, 52, 57.
Before this PR every one of these 8 charts would have been skipped (empty
workbook); now the 3 rebuildable ones export with correct data.
**Non-visual proof:**
- Worker log: `Task export_dashboard_excel[54267fdb-…] succeeded in 1.08s`
- MinIO: `dashboard-exports/5/54267fdb-….xlsx` (913 KB, 3 sheets — verified
sheet names + row counts via openpyxl)
- Mailpit email subject "…export is ready: Video Game Sales" with a working
download link and the 5 omitted charts under *"they have no saved query
context. To include them, open each chart in Explore and re-save."*
Screenshots (in `.context/empty-query-context-screenshots/`, gitignored —
attaching): `01-dashboard`, `02-download-menu` (Export Data to Excel),
`03-export-toast`, `04-email-skipped-list`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
