bito-code-review[bot] commented on code in PR #41749:
URL: https://github.com/apache/superset/pull/41749#discussion_r3640802341
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts:
##########
@@ -365,9 +317,8 @@ export function getLegendLayoutResult({
theme,
type,
}: {
- // Raw chart dimensions. Use availableWidth/availableHeight when other chart
- // UI elements reserve legend space before ECharts lays out the legend.
- availableHeight?: number;
+ // Raw chart dimensions. Use availableWidth when other chart UI elements
+ // reserve legend space before ECharts lays out the legend.
availableWidth?: number;
chartHeight: number;
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to remove `chartHeight` is incorrect in this
context. As you noted, `chartHeight` is used as a fallback for
`availableHeight` (availableHeight ?? chartHeight), so removing it from the
function signature would indeed break that logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
