rusackas commented on PR #37120: URL: https://github.com/apache/superset/pull/37120#issuecomment-5062759333
Thanks for sticking with this, @Milad93R. The new `test_export_dashboard_cross_database_charts` test is failing on CI (mysql, postgres, sqlite), only picking up one database file instead of two, so as it stands the fix doesn't actually resolve the bug it's meant to cover. Also, a few things from my last pass are still open in the current diff: `database/export.py` and `query/export.py` take a `seen` param but never read or add to it, and `ExportTagsCommand.export()` in `dashboard/export.py` still isn't passed `seen`. I'm still not clear on the actual mechanism here, `run()` already dedups by filename, so isolated `seen` sets should cause duplicates, not missing files. Can you point at the exact line on `master` where a chart or database gets dropped? Want to fix the real cause before we merge this, not just add more dedup plumbing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
