hy144328 commented on PR #42365: URL: https://github.com/apache/superset/pull/42365#issuecomment-5064866033
> db.session(future=True) in the streaming export raises if a scoped session already exists on the thread. The current call path is fine since the generator runs after teardown, but it would bite if anyone ever wraps that response in stream_with_context. I have to think about this one a little more (tomorrow). Where I do not quite follow: How is this related to setting `future`. As you described correctly, I was quite mechanical about this PR. I did not notice any existing transactions being affected by this. I was also not able to find `stream_with_context`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
