rusackas commented on PR #34640: URL: https://github.com/apache/superset/pull/34640#issuecomment-5065245384
Pre-commit is failing now that it's rebased: custom-rules-frontend flags the hardcoded `rgba(0, 0, 0, 0.5)` overlay default in Login/index.tsx, needs a theme token instead. Also still open: the two `providers.map()` blocks need `key` props, and @msyavuz's threads on the pseudo-element background, extracting a shared BrandLogo component, and the overlay-color default in dark mode. Let's get those sorted before merging, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
