villebro opened a new pull request, #232: URL: https://github.com/apache/superset-kubernetes-operator/pull/232
## Summary While reviewing the changes accumulated since 0.1.1 ahead of cutting the 0.2.0 release branch, I found that the Helm chart's two golden-snapshot test suites (minimal defaults, full-options) never exercise several conditional render branches, and a few small documentation/CI inaccuracies had crept in. This PR adds targeted test coverage for those branches and fixes the doc/CI nits, to get `main` into a solid state before the release cut. There are no operator code or CRD changes. ## Details - **`charts/superset-operator/tests/optout_and_helpers_test.yaml` (new).** A targeted-assertion helm-unittest suite that varies one knob at a time to reach render branches a single combined snapshot can't systematically cover: the `serviceAccountName` helper resolution branches, the `metrics.enabled: false` wiring (`--metrics-bind-address=0`, and the metrics Service/RBAC/ServiceMonitor rendering nothing), and the `leaderElection.enabled: false` toggle. - **`docs/contributing/development-guidelines.md`.** Correct the Helm chart tests description — the two existing suites are snapshot-only, and the new suite is what provides the targeted assertions (the previous text incorrectly attributed targeted assertions to both snapshot suites) — and name all three suites. - **`docs/user-guide/lifecycle.md`.** Clarify that migrate triggers on the resolved `repository:tag` string, so mutable tags (e.g. `latest`) or a digest repoint at the same tag do not re-run `superset db upgrade`; use a distinct tag or bump `migrate.trigger`. - **`renovate.json`.** Fix the helm-checksum `prBodyNote` to reference the actual CI check name (`Verify Helm checksum pin`). - **`scripts/verify-release-ci.sh`.** Document that E2E is intentionally not part of the release-publish gate (its matrix job names are dynamic and impractical to pin as branch-protection contexts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
