sadpandajoe opened a new pull request, #42384: URL: https://github.com/apache/superset/pull/42384
### SUMMARY Align `PooledBaseScreenshot.get_screenshot` with the optional `log_context` parameter on `BaseScreenshot.get_screenshot`. PR #42119 introduced the base-class parameter but left the pooled override unchanged, causing scheduled master pre-commit run 30073825370 to fail mypy. The pooled Selenium implementation accepts the context for interface compatibility but intentionally does not use it because its screenshot path does not emit the Playwright per-tile readiness logs. This is an automation-owned, narrow restoration from master SHA `a1142b0f91522766c9f24b73359038f05a17f20a`. It overlaps the signature hunk in #42118, but avoids coupling the CI fix to that PR's broader screenshot time-budget feature. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable; no UI change. ### TESTING INSTRUCTIONS 1. Run `pre-commit run mypy --files superset/mcp_service/screenshot/pooled_screenshot.py tests/unit_tests/mcp_service/test_pooled_screenshot.py`. 2. Run `pytest -q tests/unit_tests/mcp_service/test_pooled_screenshot.py`. 3. Run `pre-commit run --files superset/mcp_service/screenshot/pooled_screenshot.py tests/unit_tests/mcp_service/test_pooled_screenshot.py`. All scoped checks pass locally. The required `pre-commit run --all-files` was also executed; the changed-file mypy path passed, while the repository-wide command reported pre-existing oxlint and Ruff failures in untouched files. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
