github-advanced-security[bot] commented on code in PR #42399:
URL: https://github.com/apache/superset/pull/42399#discussion_r3648030104


##########
superset/commands/importers/v1/utils.py:
##########
@@ -230,7 +230,11 @@
                     prefix,
                     exc.messages,
                 )
-                logger.debug("Config content that failed validation: %s", 
config)
+                # Log field names only; full values can be huge (e.g. inline
+                # example data) and drown out the validation error above.
+                logger.debug(
+                    "Config fields present in %s: %s", file_name, 
sorted(config)

Review Comment:
   ## CodeQL / Clear-text logging of sensitive information
   
   This expression logs [sensitive data (password)](1) as clear text.
   This expression logs [sensitive data (password)](2) as clear text.
   This expression logs [sensitive data (password)](3) as clear text.
   This expression logs [sensitive data (password)](4) as clear text.
   This expression logs [sensitive data (password)](5) as clear text.
   This expression logs [sensitive data (password)](6) as clear text.
   This expression logs [sensitive data (password)](7) as clear text.
   This expression logs [sensitive data (password)](8) as clear text.
   This expression logs [sensitive data (password)](9) as clear text.
   This expression logs [sensitive data (password)](10) as clear text.
   This expression logs [sensitive data (password)](11) as clear text.
   This expression logs [sensitive data (password)](12) as clear text.
   This expression logs [sensitive data (password)](13) as clear text.
   This expression logs [sensitive data (password)](14) as clear text.
   This expression logs [sensitive data (password)](15) as clear text.
   
   [Show more 
details](https://github.com/apache/superset/security/code-scanning/2586)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to