sadpandajoe opened a new pull request, #42403: URL: https://github.com/apache/superset/pull/42403
### SUMMARY In SQL Lab's **dark theme**, clicking a column name did not readably highlight its other occurrences (sc-102561). The Ace editor uses the light `github` theme with a token-based dark-mode CSS override, but that override did not restyle `.ace_selected-word` (the "other occurrences" marker). It kept the near-white light-theme default, so the light dark-mode glyphs sitting on it were unreadable. ### CHANGES - `AsyncAceEditor/index.tsx`: add an exported `aceSelectedWordStyles(token)` `css` helper that overrides `.ace_selected-word` using the dark-aware `colorEditorSelection` token (falling back to `colorPrimaryBgHover`) plus `colorBorder`, mirroring the existing `aceCompletionHighlightStyles` pattern, and interpolate it into the `<Global>` block after the `.ace_selection` rule. - `AsyncAceEditor.test.tsx`: wiring test for the new helper. Pure theming change; no light-theme regression (the override is scoped to the dark-mode global block). ### TESTING INSTRUCTIONS 1. Switch Superset to **dark theme** and open SQL Lab. 2. Type a query with a repeated column name, then double-click one occurrence. 3. The other occurrences should be highlighted with readable contrast (previously they were near-invisible). Confirm light theme is unchanged. Before/after QA video attached below. sc-102561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
