prathamesh04 commented on PR #42216: URL: https://github.com/apache/superset/pull/42216#issuecomment-5077060180
Thanks @aminghadersohi for the thorough review! I've addressed the applied/rejected filter columns bug: - Changed to check against instead of , so only successfully resolved adhoc labels are marked as applied. - Added which mocks to raise and verifies the label appears in but NOT in . Ready for re-review. cc @rusackas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
