hainenber commented on code in PR #42430:
URL: https://github.com/apache/superset/pull/42430#discussion_r3651751044
##########
scripts/check_license.sh:
##########
@@ -44,7 +44,7 @@ acquire_rat_jar () {
# We failed to download
rm "$JAR"
printf "Our attempt to download rat locally to ${JAR} failed. Please
install rat manually.\n"
- exit -1
+ exit 255
Review Comment:
Resolves https://www.shellcheck.net/wiki/SC2242. The docs prefers using
`exit 255` as first possible exit code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
