codeant-ai-for-open-source[bot] commented on code in PR #37141:
URL: https://github.com/apache/superset/pull/37141#discussion_r3652255015
##########
superset-frontend/src/components/ListView/ListView.tsx:
##########
@@ -453,26 +490,32 @@ export function ListView<T extends object = any>({
)}
<div data-test={className} className={`superset-list-view ${className}
`}>
<div className="header">
- {cardViewEnabled && (
+ {cardViewEnabled && !forceViewMode && (
<ViewModeToggle mode={viewMode} setMode={setViewMode} />
)}
<div className="controls" data-test="filters-select">
- {filterable && (
+ {/* When a mobile drawer callback is provided, filters and sort
+ render inside the drawer instead of inline. Only one
+ FilterControls instance is ever mounted, so filtersRef and
+ filterControlsRef always point at the visible instance. */}
+ {filterable && !setMobileFiltersOpen && (
<FilterControls
ref={filterControlsRef}
filters={filters}
internalFilters={internalFilters}
updateFilterValue={applyFilterValue}
/>
)}
- {viewMode === 'card' && cardSortSelectOptions && (
- <CardSortSelect
- initialSort={sortBy}
- onChange={(value: SortColumn[]) => setSortBy(value)}
- options={cardSortSelectOptions}
- />
- )}
- {filterable && (
+ {viewMode === 'card' &&
+ cardSortSelectOptions &&
+ !setMobileFiltersOpen && (
+ <CardSortSelect
+ initialSort={sortBy}
+ onChange={(value: SortColumn[]) => setSortBy(value)}
+ options={cardSortSelectOptions}
+ />
+ )}
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Treat the presence of setMobileFiltersOpen as the intentional mobile-mode
switch; do not flag missing viewport checks when callers only pass this
callback on mobile.
**Applied to:**
- `superset-frontend/src/components/ListView/ListView.tsx`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
