Pawansingh3889 commented on PR #41799: URL: https://github.com/apache/superset/pull/41799#issuecomment-5086388046
Good catch, thanks @sha174n — the description was still describing the earlier revision that carried the `can_csv` fallback. `canDownloadData` has been a hard switch since the fallback came out on @rusackas's review, so the description was the stale part, not the code. Updated: the matrix now shows no download for a `can_csv`-only user with the flag on, testing step 1 matches, and there's a short note on why the fallback was dropped (it diverged from the backend and from `hydrateExplore`/`usePermissions`) so the history isn't lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
