SBIN2010 commented on PR #42053:
URL: https://github.com/apache/superset/pull/42053#issuecomment-5087032436
> The gradient fix and the color-util tests look great now, thanks! Two
things before I'm happy: the picker trigger lost its label — the tests had to
drop `getByLabelText('Color scheme')`, so the field isn't reachable by screen
readers anymore. Can we forward an `aria-label` to the `ColorPicker`? Taking a
look at that now...
>
> On the swatches you asked about, a `title`/tooltip per preset would keep
the green/red trend colors self-explanatory now that the descriptive labels are
gone. Looking into that too...
Hi @rusackas!
There is no tooltip in the documentation for presets.
Any ideas on how to create a tooltip for a preset trend?
One could split it into two preset sets and give them appropriate names.
'Trend. Green for increase, red for decrease' and
'Trend. Red for increase, green for decrease'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
