rusackas commented on code in PR #37516:
URL: https://github.com/apache/superset/pull/37516#discussion_r3656223899
##########
superset/explore/utils.py:
##########
@@ -53,7 +53,7 @@ def check_query_access(query_id: int) -> Optional[bool]:
# Access checks below, no need to validate them twice as they can be
expensive.
query = QueryDAO.find_by_id(query_id, skip_base_filter=True)
if query:
- security_manager.raise_for_access(query=query)
+ query.raise_for_explore_access()
Review Comment:
`raise_for_explore_access()` calls `security_manager.raise_for_access()`
internally (see `models/sql_lab.py`), plus an owner check. It's still the
centralized gate, just wrapped, same as `check_dataset_access` right above it
which uses `can_access_datasource` instead of calling `raise_for_access`
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
