anthonyhungnguyen commented on PR #35962: URL: https://github.com/apache/superset/pull/35962#issuecomment-5094838468
You're right, thanks for digging in — I couldn't find a repro on current `master` either. The per-column loop appends exactly one array per entry in `column_names` (in both the `try` path and the stringify fallback), so `pa_data` and `column_names` always end up the same length; with zero rows it just builds zero-length arrays and the columns survive. The new branch never fires. I've dropped the code hunk (reverted `result_set.py` to master) and kept only the test as a regression guard — it passes against unmodified master. Also retitled the PR to `test(...)` accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
