rusackas opened a new pull request, #42488: URL: https://github.com/apache/superset/pull/42488
### SUMMARY Master gets frequent, sometimes bursty pushes (dependency bumps, doc PRs, etc.), and each one that triggers `Python-Integration` also fires a `Docs Deployment` attempt. The `docs-deploy-asf-site` concurrency group correctly serializes the *actual builds* — this was added in #40030 because the deploy action pushes to `apache/superset-site` without rebasing, so concurrent runs race on the final push. But `cancel-in-progress: true` force-kills every superseded attempt with a `cancelled` conclusion, and GitHub's commit list renders that as a red/failing check on that commit — even though nothing is actually broken and a later run does go on to deploy successfully. Under bursty conditions this can chain for an extended stretch: I observed one master commit rack up 12 cancelled `Docs Deployment` attempts in a row over about 80 minutes before one finally got through, painting a run of otherwise-green commits red the whole time. This PR splits the workflow so the "am I still relevant?" check happens *before* anything enters the serialized group: - New `check-freshness` job runs for every trigger, outside the concurrency group, and just compares its own commit against master's live tip via `gh api`. - `build-deploy` now also requires `needs.check-freshness.outputs.is-current == 'true'`. Superseded runs skip cleanly here (a `skipped` conclusion, which doesn't redden the commit) instead of ever entering the concurrency group. - The `docs-deploy-asf-site` concurrency group (with `cancel-in-progress: true`) moves onto `build-deploy` itself and stays as a backstop for the genuine push-race case, but should now rarely have more than one real contender to cancel. No change to deploy behavior or destination — docs still deploy from whichever run is building master's current tip. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A (CI workflow change, no UI) ### TESTING INSTRUCTIONS - `pre-commit run --files .github/workflows/superset-docs-deploy.yml` passes (including the `zizmor` GHA security audit). - YAML validated with `python3 -c "import yaml; yaml.safe_load(...)"`. - Can't fully dry-run `workflow_run`/concurrency semantics locally; recommend watching the next few `Docs Deployment` runs on master after merge to confirm superseded attempts now show `skipped` instead of `cancelled`, and that a deploy still lands on `apache/superset-site` (`asf-site` branch). ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
