younsl opened a new pull request, #240:
URL: https://github.com/apache/superset-kubernetes-operator/pull/240
## Summary
Adds an optional `imagePullSecrets` value to the operator Helm chart so the
manager image can be pulled from a private registry. The chart already exposes
`image.repository`, `image.tag`, and `image.pullPolicy`, but there was no way
to attach pull credentials — users running the operator from an internal mirror
had to patch the Deployment out-of-band or attach the Secret to the
ServiceAccount manually, both of which drift from the Helm release.
The value defaults to an empty list, so
`spec.template.spec.imagePullSecrets` is omitted from the rendered Deployment
unless set and existing installs are unaffected. The referenced Secrets must
already exist in the release namespace; the chart does not create them.
## Details
- `templates/deployment.yaml` — renders `imagePullSecrets` under a `{{- with
}}` guard in the pod spec.
- `values.yaml` — new `imagePullSecrets: []` knob with a helm-docs
annotation.
- `values.schema.json` — array of objects with a required `name` string,
matching `corev1.LocalObjectReference`.
- `tests/values/full-options.yaml` + snapshot — the knob is exercised by the
comprehensive chart test, as required by `make helm-values-covered`.
- `charts/superset-operator/README.md` — regenerated via `make helm-docs`.
- `docs/reference/releases.md` — Unreleased entry.
Verified with `make helm-docs`, `make helm-values-covered`, `helm lint -f
tests/values/full-options.yaml`, and `helm unittest charts/superset-operator`
(3 suites, 9 tests, 25 snapshots passing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
