Vitor-Avila opened a new pull request, #42492:
URL: https://github.com/apache/superset/pull/42492
### SUMMARY
This PR declares sensitive fields directly in
`encrypted_extra_sensitive_fields` for Druid, Presto and Trino. This helps
improving Secure Extra to only mask real sensitive fields.
For example, currently if you save a Druid connection with Secure Extra set
to:
``` json
{
"connect_args": {
"scheme": "http",
"jwt": "<JWT_TOKEN>"
}
}
```
When editing the connection, the field would show `{"connect_args"
XXXXXXXXXX}`. This makes it very difficult to determine what the current
configuration is.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI changes.
### TESTING INSTRUCTIONS
1. Create a Druid connection with a JWT token set via `{"connect_args":
{"scheme": "http","jwt": "<JWT_TOKEN>"}}`.
2. Edit the connection, and confirm that only the `jwt` is escaped.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
