bxsx commented on code in PR #42495: URL: https://github.com/apache/superset/pull/42495#discussion_r3662026969
########## docker/pythonpath_dev/superset_config.py: ########## @@ -114,7 +114,11 @@ class CeleryConfig: } EXTENSIONS_PATH = "/app/docker/extensions" ALERT_REPORTS_NOTIFICATION_DRY_RUN = True -WEBDRIVER_BASEURL = f"http://superset_app{os.environ.get('SUPERSET_APP_ROOT', '/')}/" # When using docker compose baseurl should be http://superset_nginx{ENV{BASEPATH}}/ # noqa: E501 +# The Docker Compose app service is named "superset" and listens on 8088. Only the +# scheme/host/port matter here (paths are joined with urljoin). For screenshots in +# the dev stack (unbuilt static assets) point this at the nginx service instead: +# http://nginx{SUPERSET_APP_ROOT}/ +WEBDRIVER_BASEURL = f"http://superset:8088{os.environ.get('SUPERSET_APP_ROOT', '/')}/" Review Comment: The nginx service exists only in the dev docker-compose.yml — docker-compose-non-dev.yml has no nginx yet shares this config file (via the PYTHONPATH set in docker/.env), so defaulting to http://nginx/ would fix a niche and break non-dev entirely. http://superset:8088 is the default that maximizes what works out of the box: chart-data fetches (text/CSV reports, alerts) work on both stacks, and screenshots work on non-dev (built assets). Screenshots on the dev stack already require an opt-in image rebuild (INCLUDE_CHROMIUM=true), so pointing those setups at nginx is a documented override (see the comment) rather than the default. Splitting data-fetch and screenshot base URLs would be a new config surface — out of scope for this fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
