rusackas commented on PR #42392: URL: https://github.com/apache/superset/pull/42392#issuecomment-5099455316
Thanks for tracking this down, the crash makes sense given how quickly formData can go stale mid-navigation. Could you add a quick test for `transformProps` with `metrics` undefined/empty, similar to `legacy-plugin-chart-country-map/test/transformProps.test.ts`? There's no test folder at all in this plugin yet, and this is exactly the kind of regression a test would solidify for any future tweaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
