rusackas commented on PR #40815: URL: https://github.com/apache/superset/pull/40815#issuecomment-5099501923
Thanks for digging into this, @msyavuz. This is a legit leak and failing closed is the right call. One thing to check on: `useMatrixifyAllowedValues`'s state only resets inside the effect, so if `formData`'s dimension column changes after a prior fetch resolved, one render can use the stale `allowedByColumn` (missing the new column, so effectively unfiltered) before status flips back to loading. Worth confirming/fixing that gap since the whole point here is never rendering unfiltered, even briefly. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
