rusackas commented on PR #42190: URL: https://github.com/apache/superset/pull/42190#issuecomment-5099511109
Thanks for chasing these shims down and confirming `npm run dev` still works without them. One thing before merging: `plugin-chart-ag-grid-table/src/index.ts` still has the leftover "must export something..." comment sitting above the line you removed, the other two files already dropped theirs along with the export. LGTM otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
