prathamesh04 commented on PR #42412: URL: https://github.com/apache/superset/pull/42412#issuecomment-5100153282
Hi @sha174n — I have pushed the update addressing both points: 1. **Streaming preserved**: Added `cursor.arraysize = limit` after cursor creation. This ensures DBAPI drivers (Trino, PostgreSQL, etc.) fetch rows in batches of `limit` rows via `fetchmany()`, not buffering the entire result set. The `fetchmany(limit)` call in `_process_rows` already controls batch size, so streaming is preserved. 2. **CI**: All tests should pass now. The `arraysize` is set before execution, matching the old `stream_results=True` behavior. Thanks for the thorough review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
