bito-code-review[bot] commented on code in PR #38126:
URL: https://github.com/apache/superset/pull/38126#discussion_r3665153919
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts:
##########
@@ -399,7 +402,9 @@ describe('EchartsTimeseries transformProps', () => {
result.echartOptions.series as SeriesOption[] | undefined
)?.find((s: SeriesOption) => s.name === 'My Formula');
expect(formulaSeries).toBeDefined();
- const firstDataPoint = (formulaSeries!.data as [number, number][])[0];
+ const series = formulaSeries as SeriesOption;
+ const data = series.data as [number, number][];
+ const firstDataPoint = data[0];
expect(firstDataPoint).toBeDefined();
expect(firstDataPoint[0]).toBe(firstDataPoint[1] * 2);
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing defensive array checks</b></div>
<div id="fix">
The second hunk (lines 404-409) lacks the array validation checks
(`Array.isArray` and `length > 0`) that the first hunk (lines 322-325) now
includes. Without these guards, accessing `data[0]` could throw a TypeError if
`data` is undefined or empty.
</div>
</div>
<small><i>Code Review Run #ee0582</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
