rusackas commented on PR #42095: URL: https://github.com/apache/superset/pull/42095#issuecomment-5107848935
Really appreciate how deep the root-cause writeup goes here, and using a tokenizer instead of a full SQLGlot reserialization is a smart way to keep the blast radius small. One thing I'm curious about: `netezza.py` also inherits `PostgresBaseEngineSpec` and defines its own lowercase `DATE_TRUNC` time grains, same pattern as Postgres/Redshift, but it's not in `POSTGRES_FAMILY_ENGINES` and doesn't get the `normalize_custom_sql_metric` override. Same bug there too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
