rusackas commented on PR #42339: URL: https://github.com/apache/superset/pull/42339#issuecomment-5108545251
Thanks for sticking with this, @prathamesh04. Bito's parent-contract thread is still valid though, `run()` never calls `validate()`, `self.dao`, or `self._export()`, and `model_ids` gets stored in `__init__` but does nothing in `run()` (superset/commands/tag/export.py:37-54). So `ExportTagsCommand(model_ids=[...]).run()` silently exports nothing. That's the actual behavior #40766 wanted aligned, not just the class declaration. Also the old `export()` staticmethod is still sitting there duplicating `run()`'s logic even though nothing calls it anymore. Worth deleting rather than carrying it as dead code, otherwise the two will drift. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
