Copilot commented on code in PR #42471: URL: https://github.com/apache/superset/pull/42471#discussion_r3669189111
########## superset-frontend/plugins/legacy-plugin-chart-country-map/scripts/Country Map GeoJSON Generator.ipynb: ########## Review Comment: This renames `level_id` to `iso_3166_2`, but the WHO AFRO `level_id` values appear to be custom admin identifiers (e.g. `MDG-...`), not ISO-3166-2 subdivision codes. Using the `iso_3166_2` column name here makes the generator misleading and reinforces the mismatch with the Country Map documentation. Consider renaming this column to something like `admin1_id` / `region_id` and only mapping it to the GeoJSON `ISO` property at the final export step (or updating the docs to reflect the use of custom admin IDs for Madagascar). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
