yousoph commented on PR #39434: URL: https://github.com/apache/superset/pull/39434#issuecomment-5110604086
hi @jaymasiwal ! thanks for working on this, looking forward to seeing the color picker in action soon :) a few notes on the UI from @kasiazjc and I: * For the series label, could we have a dropdown to select from a list of series labels that are already present in the dashboard, with the ability to add a label that isn't in the list by typing in the input? Similar to what exists in the dashboard filter bar https://github.com/user-attachments/assets/99a8f842-a96c-466e-87ec-b60dc93eba50 * Could we use a pattern similar to what we have in the Alerts & Reports with filters (ALERT_REPORTS_FILTER feature flag): * Series label with dropdown on the left, color picker on the right * Add more text link underneath the label/color rows * Delete button on the right of the row * When an existing series label is selected, it gets removed from the subsequent dropdowns to prevent duplicates <img width="485" height="182" alt="image" src="https://github.com/user-attachments/assets/88ef1f23-786e-4415-8f60-c6ca263b4c73"; /> Thanks!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
