bito-code-review[bot] commented on code in PR #42151:
URL: https://github.com/apache/superset/pull/42151#discussion_r3670338316
##########
superset-frontend/plugins/plugin-chart-echarts/src/Pie/controlPanel.tsx:
##########
@@ -325,9 +325,8 @@ const config: ControlPanelConfig = {
description: t(
'Total angle covered by the chart, in degrees. ' +
'360° draws a full circle and 180° draws a half donut. ' +
- 'When the sweep is 180° or less and the start angle is a ' +
- 'multiple of 90°, the chart is automatically re-centered ' +
- 'to make use of the empty space.',
+ 'Partial arcs are automatically re-centered and scaled ' +
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inaccurate doc for partial arcs</b></div>
<div id="fix">
The new description claims all partial arcs are 're-centered and scaled,'
but lateral half-donuts (start angles 90° or 270°) only re-center without
scaling, as shown by the test at transformProps.test.ts line 658-663.
</div>
</div>
<small><i>Code Review Run #57b7b5</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
