rusackas commented on PR #37367:
URL: https://github.com/apache/superset/pull/37367#issuecomment-5113825557

   @YuriyKrasilnikov thanks for slimming this down, the reorder matches the 
ordering issue I flagged last review.
   
   One thing before this can merge, though: `preamble.test.ts` is red on CI. 
`master` moved to `/language_pack/${lang}/` (no `/superset` prefix) as part of 
#36893, but the new test still asserts the old `/superset/language_pack/fr/` 
path. Needs a rebase and that assertion updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to