chkang-idk2 commented on code in PR #42559:
URL: https://github.com/apache/superset/pull/42559#discussion_r3672282410
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts:
##########
@@ -46,6 +46,9 @@ const getCrossFilterDataMask =
labelMap: Record<string, string[]>,
) =>
(value: string) => {
+ if (!labelMap[value]) {
+ return undefined;
+ }
Review Comment:
After this change, clicking "Other" (or any name missing from labelMap)
never calls setDataMask, so "Other" cannot enter selectedValues through this
chart's cross-filter path in the first place.
The only remaining case would be a stale selection left over from before the
fix, which can be cleared via the dashboard's Clear all filters. Given that,
the unconditional early return seems sufficient for the reported bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
